Uploaded image for project: 'Specifications - Archetype model'
  1. SPECAM-43

Correct C_TERMINOLOGY_CODE.c_conforms_to to handle no parent value-set

    Details

    • Type: Change Request
    • Status: In Review
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: ADL 2.0
    • Fix Version/s: ADL 2.0.7
    • Component/s: AOM, Documentation
    • Labels:
      None
    • Impact Analysis:
      Limited, but will require a small change in all AOM2-based archetype validating tools. Already implemented in ADL Workbench.
    • Change Description:
      Hide
      The following change was made to the code in section http://www.openehr.org/releases/AM/latest/docs/AOM2/AOM2.html#_conformance_semantics_8 of the AOM2 spec.

      if is_valid_value_set_code (constraint) and is_valid_value_set_code (other.constraint) then
      -- firstly, check if the other value-set is empty, which means there is no value-set, i.e. no constraint
      -- which means that this object's value set automatically conforms.
      other_vset := other.value_set_expanded
      if not other_vset.is_empty then -- ************ ADDED
      this_vset := value_set_expanded
      Result := codes_conformant (constraint, other.constraint) and then
      across this_vset as vset_csr all other_vset.has (vset_csr.item) end
      else -- ************ ADDED
      Result := True -- ************ ADDED
      end
      Show
      The following change was made to the code in section http://www.openehr.org/releases/AM/latest/docs/AOM2/AOM2.html#_conformance_semantics_8 of the AOM2 spec. if is_valid_value_set_code (constraint) and is_valid_value_set_code (other.constraint) then -- firstly, check if the other value-set is empty, which means there is no value-set, i.e. no constraint -- which means that this object's value set automatically conforms. other_vset := other.value_set_expanded if not other_vset.is_empty then -- ************ ADDED this_vset := value_set_expanded Result := codes_conformant (constraint, other.constraint) and then across this_vset as vset_csr all other_vset.has (vset_csr.item) end else -- ************ ADDED Result := True -- ************ ADDED end

      Description

      The current code in the spec at http://www.openehr.org/releases/AM/latest/docs/AOM2/AOM2.html#_conformance_semantics_8 doesn't currently handle the situation where there is no value set in the parent, but should.

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                thomas.beale Thomas Beale
                Reporter:
                thomas.beale Thomas Beale
                Raised By:
                Pieter Bos
                Analyst:
                Thomas Beale
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0.5d
                  0.5d
                  Remaining:
                  Remaining Estimate - 0.5d
                  0.5d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified