Allow +14:00 timezone

Description

The Time types from Foundation allows currently only timezone with max +13. There is however another registered timezone with +14:00.

This was fixed in XML schema and probably addressed in a form or another in Release 1.0.2, but currently the BASE does not support +14:00.

See also https://en.wikipedia.org/wiki/UTC%2B14:00 and https://upload.wikimedia.org/wikipedia/commons/8/88/World_Time_Zones_Map.png

Activity

Show:
Sebastian Iancu
March 16, 2021, 11:52 AM

That would be good to have this automated with the extractor, but for now if you could just manually fix the specs would be enough (it will contribute to solve reported REST issue around DT format)

Thomas Beale
March 16, 2021, 11:47 AM
Edited

I remember this issue of the 14:00 TZ from ages ago… I can’t believe we didn’t make the changes on these class definitions, but … it appears we didn’t.

We should standardise these regex expressions for all of openEHR. We currently have regexes in the antlr4 grammars that I think are correct. It’s not that easy to re-use them so I might copy them to the Time_definitions class so we have a formal statement of them (if I get the UML → BMM extractor developed, such regexes will appear in the BMM as constant values, and they will then flow through to code-generation, JSON-schema etc). And then adjust the various class texts. may have an opinion on this.

Sebastian Iancu
March 15, 2021, 1:25 PM

, while you’re working on this, can you also fix few other small inconsistencies across time related classes (see their header infos):

  • the timezone part of extended format should be ....[Z|±hh[:mm]] so with and extra : before the mm

  • the milliseconds part should accept both comma , as well as dot . so [(,|.)s+] or [(,|.)sss] instead of [,sss]

Done

Reporter

Sebastian Iancu

Raised By

Sebastian Iancu