Details

    • Impact Analysis:
      Hide
      • ambiguity confirmed, cause by old Archetypes.XSD definition vs new BaseType specification (no XSD definition yet).

      If type would be changed according to the latest specifications, it will have a major impact on validating AOM1.4 archetype XMLs using Archetypes.XSD, no impact otherwise - such change would normally break existing data instances, but fortunately this type existed (and was used) only in Archetype.XSD. See original definition.
      https://specifications.openehr.org/releases/1.0.2/architecture/am/aom.pdf

      This type/class was moved later to BaseTypes and had its signature changed - therefore the new XSDs should contain it and should comply with released specifications.

      Show
      ambiguity confirmed, cause by old Archetypes.XSD definition vs new BaseType specification (no XSD definition yet). If type would be changed according to the latest specifications, it will have a major impact on validating AOM1.4 archetype XMLs using Archetypes.XSD, no impact otherwise - such change would normally break existing data instances, but fortunately this type existed (and was used) only in Archetype.XSD. See original definition. https://specifications.openehr.org/releases/1.0.2/architecture/am/aom.pdf This type/class was moved later to BaseTypes and had its signature changed - therefore the new XSDs should contain it and should comply with released specifications.
    • Change Description:
      Hide

      committed two version of this type in the BASE/BaseTypes.xsd component so that it reflects corresponding specifications.

      Show
      committed two version of this type in the BASE/BaseTypes.xsd component so that it reflects corresponding specifications.

      Description

      There is a problem with VALIDITY_KIND.

      The specification http://www.openehr.org/releases/BASE/latest/docs/base_types/base_types.html#_validity_kind_enumeration defines 3 values:

      * mandatory
      * optional
      * prohibited

      The XSD defines the values in a different way and as an INTEGER
      https://github.com/openEHR/specifications-ITS/blob/master/RM/XML-schema/Archetype.xsd

      <xs:simpleType name="VALIDITY_KIND">
      <xs:restriction base="xs:integer">
      <xs:enumeration value="1001" id="mandatory"/>
      <xs:enumeration value="1002" id="optional"/>
      <xs:enumeration value="1003" id="disallowed"/>
      </xs:restriction>
      </xs:simpleType>



      There are two issues here:

      1. Disallowed and prohibited are used for what seems to be the same "enumeration"
      2. The numbers used in XSD is not defined in the specification.

      Suggestion:

      Change XSD into something like this: https://github.com/bjornna/specifications-ITS/blob/taskplanning/RM/XML-schema/TaskPlan.xsd

       <xs:simpleType name="VALIDITY_KIND">
              <xs:restriction base="xs:string">
                  <xs:enumeration value="mandatory"/>
                  <xs:enumeration value="optional"/>
                  <xs:enumeration value="prohibited"/>
              </xs:restriction>
          </xs:simpleType>

        Attachments

          Activity

              People

              • Assignee:
                Sebastian Iancu
                Reporter:
                Bjørn Næss
                Raised By:
                Bjørn Næss
                Analyst:
                Sebastian Iancu
                Acceptance:
                Diego Bosca, Sebastian Iancu
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified