Change VERSION.uid() method to be an attribute VERSION.uid like it is on the subclasses IMPORTED_VERSION and ORIGINAL_VERSION.

Description

The method adds nothing but complexity to the model and it's implementations, and obscures meaning and interpretation.

The model will be simpler with the uid as an attribute in VERSION without secondary effects.

Also, remove the attribute from subclasses.

Environment

None

Activity

Show:
Thomas Beale
April 25, 2018, 4:50 PM

We could potentially modify the UML to look more like implementations. Need input from implementers.

Bjørn Næss
April 26, 2018, 6:13 AM

We have always implementedthis as an attribute.

Pablo Pazos
April 28, 2018, 5:14 PM

I have the uid also as an attribute (in an object that can be accessed by a getter method).

Also my implementation only supports ORIGINAL_VERSION.

Thomas Beale
May 1, 2018, 7:52 PM

I'm don't see how it makes sense to have VERSION.uid be a property which would be inherited into IMPORTED_VERSION, which doesn't have a uid attribute, but rather a method to get the uid from the connected ORIGINAL_VERSION.

Thomas Beale
November 6, 2018, 3:07 PM

others in the SEC recognise that the UML is not an exact match for code, but it is very close in PHP and C#, and close enough to what it would be in Java. The main point is that uid is a function in IMPORTED_VERSION and only a stored property in ORIGINAL_VERSION.

Reporter

Pablo Pazos

Labels

None

Components

Affects versions

Priority

Major
Configure