Correct arithmetic and comparison functions in Data Types

Description

Currently the RM Data Types, particularly DV_ORDERED and the date/time types do not contain correct definitions of functions and operators like 'less_than()', 'add()' etc.

Activity

Show:
Thomas Beale
April 30, 2020, 8:34 AM

I’ve just pushed a change that has the errors corrected (including the last one).

For the precision question, I would say that in your example, the precision is still 2, i.e. the precision of the lowest precision element in the expression. Which possibly really requires rounding up to +/- 0.6

Matija Polajnar
May 8, 2020, 8:10 AM
Edited

I think you refer to the method by two names, is_strictly_comparable and is_strictly_comparable_to. Please double-check that. Other than that, I'll accept this although I did not review it as strictly as I should (and as Sebastian did, great work!).

Sebastian Garde
June 15, 2020, 1:40 PM

Yes, have a search for strictly or so, and it will return the differences mentions. Other than that, looks good.

Sebastian Iancu
June 20, 2020, 9:31 AM

issue with is_strictly_comparable still there, otherwise looks good.

This will also require latest changes in BASE to be released, isn’t it?

Thomas Beale
June 20, 2020, 10:46 AM

I fixed the is_strictly_comparable(_to) problem. Just having a look at what we need in BASE…

Reporter

Thomas Beale

Raised By

Thomas Beale

Components

Affects versions

Configure