Term definitions code clash in opt
Description
Environment
Attachments
- 16 Mar 2016, 10:24 PM
Activity
Chunlan Ma March 23, 2020 at 11:35 AM
TD-155 mentioned a similar issue, but it didn’t make any changes to support value sets with the same code, but different terminology id. For now, For now, an error message is shown when generating an OPT from a template that has value sets with the same code, but different terminology id.
Although the proposed changes by Koray make sense from semantic perspective, this proposed changes require OPT data model changes.
Koray Atalag March 17, 2016 at 1:56 AM
OK looking at how term_bindings are handled I would suggest to add an XML attribute "terminology_id" to term_definitions in addition to "code" for non-at code entries; it is also important to add release/version to terminology as well (e.g. NCBI Taxonomy 2016 release)
Currently:
<term_definitions code="9615">
My proposal:
<term_definitions terminology_id="ncbi taxonomy(2016)" code="9615">
Details
Details
Assignee
Reporter
Components
Priority
Major
When valuesets with same code but from different terminology are entered in the resulting opt there is no way which one should be selected for intended term bindings. See:
opt:
<term_definitions code="9615">
<items id="text">Canis lupus familiaris</items>
</term_definitions>
<term_definitions code="9615">
<items id="text">Same code as Canis lupus familiaris</items>
</term_definitions>
oet:
<Rule path="/context/other_context[at0001]/items[at0003]">
<constraint xsi:type="textConstraint">
<includedValues>ncbi taxonomy::9615::Canis lupus familiaris</includedValues>
</constraint>
</Rule>
<Rule path="/context/other_context[at0001]/items[at0004]">
<constraint xsi:type="textConstraint">
<includedValues>whateverterminology::9615::Same code as Canis lupus familiaris</includedValues>
</constraint>
</Rule>
In the opt there should be a way to specify non-at codes together with terminology identifier (I think) (e.g. <term_definitions code="ncbi taxonomy::9615">)